[freenet-dev] [freenet-cvs] r19693 - trunk/freenet/src/freenet/support/io

[Matthew Toseland]

On Saturday 03 May 2008 12:45, nextgens at freenetproject.org wrote:
> Author: nextgens
> Date: 2008-05-03 11:45:09 +0000 (Sat, 03 May 2008)
> New Revision: 19693
> 
> Modified:
>    
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java
> Log:
> Some paranoia (flush() before close() just in case a BufferedOutputStream is 
catching exceptions)

Shouldn't you catch and log the exception from flush()?
> 
> Modified: 
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java
> ===================================================================
> --- 
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java	
2008-05-03 11:25:50 UTC (rev 19692)
> +++ 
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java	
2008-05-03 11:45:09 UTC (rev 19693)
> @@ -194,6 +194,7 @@
>  				}
>  			} finally {
>  				closed = true;
> +				out.flush();
>  				out.close();
>  			}
>  		}
> 
> _______________________________________________
> cvs mailing list
> cvs at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://emu.freenetproject.org/pipermail/devl/attachments/20080503/189e4653/attachment.pgp