[freenet-dev] [freenet-cvs] r17321 - trunk/freenet/src/freenet/crypt

[Florent Daignière]

* Matthew Toseland <toad at amphibian.dyndns.org> [2008-01-28 14:18:15]:

> On Sunday 27 January 2008 13:59, nextgens at freenetproject.org wrote:
> > Author: nextgens
> > Date: 2008-01-27 13:59:36 +0000 (Sun, 27 Jan 2008)
> > New Revision: 17321
> > 
> > Modified:
> >    trunk/freenet/src/freenet/crypt/DSA.java
> > Log:
> > doh2
> > 
> > Modified: trunk/freenet/src/freenet/crypt/DSA.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/crypt/DSA.java	2008-01-27 13:58:03 UTC (rev 
> 17320)
> > +++ trunk/freenet/src/freenet/crypt/DSA.java	2008-01-27 13:59:36 UTC (rev 
> 17321)
> > @@ -72,7 +72,7 @@
> >              BigInteger k;
> >  		do {
> >  			k=new NativeBigInteger(DSAGroup.Q_BIT_LENGTH, r);
> > -		} while ((g.getQ().compareTo(k) < 1) || (k.compareTo(BigInteger.ZERO) == 
> 0));
> > +		} while ((g.getQ().compareTo(k) < 1) || (k.compareTo(BigInteger.ZERO) < 
> 1));
> 
> Again, can NativeBigInteger return a negative number here?

It's just paranoia... won't harm much here
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://emu.freenetproject.org/pipermail/devl/attachments/20080129/bf045bc5/attachment.pgp