[freenet-dev] [freenet-cvs] r16839 - trunk/freenet/src/freenet/node

[Matthew Toseland]

On Saturday 29 December 2007 13:34, nextgens at freenetproject.org wrote:
> Author: nextgens
> Date: 2007-12-29 13:34:33 +0000 (Sat, 29 Dec 2007)
> New Revision: 16839
> 
> Modified:
>    trunk/freenet/src/freenet/node/FNPPacketMangler.java
> Log:
> jfk: Fix the issue spotted by robert (see 
http://archives.freenetproject.org/message/20071229.105331.b1a491f0.en.html)
> 
> That might solve the "I've lost the exponential" problem

It might? Wouldn't the old code cause an NPE?
> 
> Modified: trunk/freenet/src/freenet/node/FNPPacketMangler.java
> ===================================================================
> --- trunk/freenet/src/freenet/node/FNPPacketMangler.java	2007-12-29 09:36:50 
UTC (rev 16838)
> +++ trunk/freenet/src/freenet/node/FNPPacketMangler.java	2007-12-29 13:34:33 
UTC (rev 16839)
> @@ -2640,8 +2640,8 @@
>  					return result;
>  				}
>  			}
> -			//FIXME: Isn't this wrong? 'result.myExponential' should be exponential? 
And what if dhContextToBePrunned is null?
> -			if((dhContextToBePrunned.myExponential).equals(result.myExponential))
> +			
> +			if((dhContextToBePrunned != null) && 
((dhContextToBePrunned.myExponential).equals(exponential)))
>  				return dhContextToBePrunned;
>  		}
>  		return null;
> 
> _______________________________________________
> cvs mailing list
> cvs at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://emu.freenetproject.org/pipermail/devl/attachments/20080103/5a926a5b/attachment.pgp