[freenet-dev] [freenet-cvs] r19291 - trunk/freenet/src/freenet/keys

[Matthew Toseland]

On Monday 14 April 2008 03:44, nextgens at freenetproject.org wrote:
> Author: nextgens
> Date: 2008-04-14 02:44:11 +0000 (Mon, 14 Apr 2008)
> New Revision: 19291
> 
> Modified:
>    trunk/freenet/src/freenet/keys/FreenetURI.java
> Log:
> doh... even though it doesn't matter yet it might with other keytypes
> 
> Modified: trunk/freenet/src/freenet/keys/FreenetURI.java
> ===================================================================
> --- trunk/freenet/src/freenet/keys/FreenetURI.java	2008-04-14 02:42:33 UTC 
(rev 19290)
> +++ trunk/freenet/src/freenet/keys/FreenetURI.java	2008-04-14 02:44:11 UTC 
(rev 19291)
> @@ -643,10 +643,8 @@
>  			dis.readFully(cryptoKey);
>  			// Number of bytes of extra depends on key type
>  			int extraLen;
> -			if(type == CHK)
> +			if((type == CHK) || (type == SSK))
>  				extraLen = ClientCHK.EXTRA_LENGTH;
> -			else //if(type == SSK)
> -				extraLen = ClientSSK.EXTRA_LENGTH;

Eh?!?!?!?!

What are you doing here, apart from breaking FreenetURI? Obviously an SSK 
needs ClientSSK.EXTRA_LENGTH and a CHK needs ClientCHK.EXTRA_LENGTH ... ???

>  			extra = new byte[extraLen];
>  			dis.readFully(extra);
>  		}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://emu.freenetproject.org/pipermail/devl/attachments/20080414/4585c89a/attachment.pgp