[freenet-dev] Looking for janitor works / small tasks in freenet

[Daniel Cheng]

On Fri, Apr 4, 2008 at 4:43 AM, Matthew Toseland
<toad at amphibian.dyndns.org> wrote:
> On Thursday 03 April 2008 02:25, you wrote:
>  > Dear list,
>  >
>  > I am new on this list and wants to contrib to the freenet community
>  > and wants to understand freenet archiecture.
>  >
>  > I am proficient in both C and Java, and did have some (basic) idea on
>  > how P2P network (mainly Chord and ed2k) works, some experience in
>  > debugging thread synchronization problem. I think I can contribute
>  > around 5 hours a week, so I am here looking for some *small* and
>  > *self-contained* tasks that I can do. ....
>  >
>  > Here is a list of tasks I think I can handle (and interested):
>  >
>  >    (1) rework the dbd-index storage backend to fix the "FIXME" tasks
>  >         (if I am lucky, this should fix the deadlock bug in bug
>  > database as well)
>
>  I'm not sure what FIXMEs you are referring to.

Search "FIXME" in BerkeleyDBFreenetStore.java,
cleaner and cleverer recovery and error handleing

>  The deadlock bug isn't a java level deadlock, it's a timeout in the database.

I knew, but I think that's something fixable.. should be some
reordering of lock acquiring.

>  We haven't seen many complaints recently.

so you means bug #2101 should be closed?
KSK at frost|message|news|2008.4.3-freenet.0.7.bugs-26.xml say its on build1131

>  Having said that, there is plenty of work to do on the datastore e.g.
>  invalid/deleted blocks should be moved to the bottom of the LRU rather than
>  kept on a free blocks list.
>
>
>  >    (2) fix the warnings from static analysis tools (such as FindBugs and
>  PMD)
>
>  Usually a good idea.
>

Did you saw my patches on freenet.0.7.bugs frost board ?
If not, I will resend that here..

> >
>  >    (3) rework some thread synchronization using java5 java.util.concurrent.*
>  >         this should make the code much shorter and clearer.
>
>  Please don't use any java 5. At the moment there is no functional, stable,
>  open source JVM supporting java 5, therefore we code to java 1.4.
>
> >
>  >    (4) write (and clarify) javadocs
>
>  Always a good idea. Unit tests are nice too. Otherwise just pick a bug from
>  the bug tracker.

Okay,
will do.

> >
>  > If you want my help (or have other suggestions), please reply. I won't
>  > start working on these works until I have your explicit agreement.
>  >
>  > Regards,
>  > Daniel Cheng
>


Regards,
Daniel Cheng