[freenet-dev] [freenet-cvs] r16744 - trunk/freenet/src/freenet/node

[Matthew Toseland]

Is this wise? It usually indicates a moderately serious problem, if there are 
many of them there may be e.g. a link layer bug ... ? I suppose eventually 
we'll get a PacketSequenceException in that case, so maybe NORMAL? These 
could also indicate deliberate replays, though I don't see much point, and we 
may not want to log them if so..

On Thursday 20 December 2007 16:25, robert at freenetproject.org wrote:
> Author: robert
> Date: 2007-12-20 16:25:53 +0000 (Thu, 20 Dec 2007)
> New Revision: 16744
> 
> Modified:
>    trunk/freenet/src/freenet/node/FNPPacketMangler.java
> Log:
> demote 'received packet twice' message
> 
> 
> Modified: trunk/freenet/src/freenet/node/FNPPacketMangler.java
> ===================================================================
> --- trunk/freenet/src/freenet/node/FNPPacketMangler.java	2007-12-20 15:40:38 
UTC (rev 16743)
> +++ trunk/freenet/src/freenet/node/FNPPacketMangler.java	2007-12-20 16:25:53 
UTC (rev 16744)
> @@ -1904,7 +1904,7 @@
>  
>  		if((seqNumber != -1) && tracker.alreadyReceived(seqNumber)) {
>  			tracker.queueAck(seqNumber); // Must keep the connection open!
> -			Logger.error(this, "Received packet twice ("+seqNumber+") 
from "+tracker.pn.getPeer()+": "+seqNumber+" ("+TimeUtil.formatTime((long) 
tracker.pn.pingAverage.currentValue(), 2, true)+" ping avg)");
> +			if(logMINOR) Logger.minor(this, "Received packet twice ("+seqNumber+") 
from "+tracker.pn.getPeer()+": "+seqNumber+" ("+TimeUtil.formatTime((long) 
tracker.pn.pingAverage.currentValue(), 2, true)+" ping avg)");
>  			return;
>  		}
>  
> 
> _______________________________________________
> cvs mailing list
> cvs at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://emu.freenetproject.org/pipermail/devl/attachments/20071221/751971a7/attachment.pgp