[freenet-dev] [freenet-cvs] r16372 - trunk/freenet/src/freenet/node

[Robert Hailey]

On Dec 7, 2007, at 12:34 PM, Matthew Toseland wrote:

> Some issues..
>
> Careful here! IMHO we need to include the opennet messages in the  
> bytes total
> for the request. finishOpennetNoReply() may sendAsync a
> FNPOpennetCompletedAck or an actual noderef...

Ah, yes. I changed the ack in both open net finish..() to  
sendTerminal(), and moved applyByteCounts() to the error condition  
(when no ack is sent).

> It's a sensible check but afaics you haven't implemented it - where  
> is once
> set to false?!

Quite right. Both fixed in r16398.

--
Robert Hailey