[freenet-cvs] r12183 - in trunk/freenet/src/freenet: client config crypt io io/comm io/xfer node node/fcp support

nextgens at freenetproject.org nextgens at freenetproject.org
Sat Mar 17 14:47:49 UTC 2007


Author: nextgens
Date: 2007-03-17 14:47:47 +0000 (Sat, 17 Mar 2007)
New Revision: 12183

Modified:
   trunk/freenet/src/freenet/client/StandardOnionFECCodec.java
   trunk/freenet/src/freenet/config/FreenetFilePersistentConfig.java
   trunk/freenet/src/freenet/crypt/DSAGroup.java
   trunk/freenet/src/freenet/io/NetworkInterface.java
   trunk/freenet/src/freenet/io/comm/UdpSocketManager.java
   trunk/freenet/src/freenet/io/xfer/BlockTransmitter.java
   trunk/freenet/src/freenet/node/Node.java
   trunk/freenet/src/freenet/node/fcp/FCPServer.java
   trunk/freenet/src/freenet/support/FileLoggerHook.java
Log:
Change notify() to notifyAll() in many places : most are sensible, some might not be.

review would be welcome.

Modified: trunk/freenet/src/freenet/client/StandardOnionFECCodec.java
===================================================================
--- trunk/freenet/src/freenet/client/StandardOnionFECCodec.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/client/StandardOnionFECCodec.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -60,7 +60,7 @@
 				Logger.minor(this, "Splitfile encode: k="+k+", n="+n+" encode took "+(endTime-startTime)+"ms");
 			finished = true;
 			synchronized(this) {
-				notify();
+				notifyAll();
 			}
 		}
 
@@ -187,7 +187,7 @@
 		} finally {
 			synchronized(runningDecodesSync) {
 				runningDecodes--;
-				runningDecodesSync.notify();
+				runningDecodesSync.notifyAll();
 			}
 		}
 	}
@@ -359,7 +359,7 @@
 		} finally {
 			synchronized(runningDecodesSync) {
 				runningDecodes--;
-				runningDecodesSync.notify();
+				runningDecodesSync.notifyAll();
 			}
 		}
 	}

Modified: trunk/freenet/src/freenet/config/FreenetFilePersistentConfig.java
===================================================================
--- trunk/freenet/src/freenet/config/FreenetFilePersistentConfig.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/config/FreenetFilePersistentConfig.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -72,7 +72,7 @@
 		synchronized (this) {
 			if(hasNodeStarted) Logger.error(this, "It has already been called! that shouldn't happen!");
 			this.hasNodeStarted = true;
-			notify();
+			notifyAll();
 		}
 	}
 }

Modified: trunk/freenet/src/freenet/crypt/DSAGroup.java
===================================================================
--- trunk/freenet/src/freenet/crypt/DSAGroup.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/crypt/DSAGroup.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -203,7 +203,7 @@
                 qg.qs.removeElementAt(0);
 
                 synchronized (qg) {
-                    qg.notify();
+                    qg.notifyAll();
                 }
             } else
                 q = makePrime(DSAGroup.Q_BIT_LENGTH, 80, r);

Modified: trunk/freenet/src/freenet/io/NetworkInterface.java
===================================================================
--- trunk/freenet/src/freenet/io/NetworkInterface.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/io/NetworkInterface.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -333,7 +333,7 @@
 					if (addressMatched) {
 						synchronized (syncObject) {
 							acceptedSockets.add(clientSocket);
-							syncObject.notify();
+							syncObject.notifyAll();
 						}
 					} else {
 						try {

Modified: trunk/freenet/src/freenet/io/comm/UdpSocketManager.java
===================================================================
--- trunk/freenet/src/freenet/io/comm/UdpSocketManager.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/io/comm/UdpSocketManager.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -313,7 +313,7 @@
 					f.setMessage(null);
 					synchronized (f) {
 						i.remove();
-						f.notify();
+						f.notifyAll();
 					}
 				} else { // Because _filters are in order of timeout, we
 					// can abort the iteration as soon as we find one that
@@ -361,7 +361,7 @@
 					f.setMessage(m);
 					synchronized (f) {
 						i.remove();
-						f.notify();
+						f.notifyAll();
 					}
 					if(logMINOR) Logger.minor(this, "Matched: "+f);
 					break; // Only one match permitted per message
@@ -410,7 +410,7 @@
 						f.setMessage(m);
 						synchronized (f) {
 							i.remove();
-							f.notify();
+							f.notifyAll();
 						}
 						if(logMINOR) Logger.minor(this, "Matched: "+f);
 						break; // Only one match permitted per message

Modified: trunk/freenet/src/freenet/io/xfer/BlockTransmitter.java
===================================================================
--- trunk/freenet/src/freenet/io/xfer/BlockTransmitter.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/io/xfer/BlockTransmitter.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -192,7 +192,7 @@
 						synchronized(_senderThread) {
 							_unsent.addLast(new Integer(packetNo));
 							_sentPackets.setBit(packetNo, false);
-							_senderThread.notify();
+							_senderThread.notifyAll();
 						}
 					}
 

Modified: trunk/freenet/src/freenet/node/Node.java
===================================================================
--- trunk/freenet/src/freenet/node/Node.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/node/Node.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -3493,7 +3493,7 @@
 
 		void interrupt() {
 			synchronized(this) {
-				notify();
+				notifyAll();
 			}
 		}
 		

Modified: trunk/freenet/src/freenet/node/fcp/FCPServer.java
===================================================================
--- trunk/freenet/src/freenet/node/fcp/FCPServer.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/node/fcp/FCPServer.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -297,7 +297,7 @@
 			FCPServerPersister p = server.persister;
 			if(p != null) {
 				synchronized(p) {
-					p.notify();
+					p.notifyAll();
 				}
 			}
 		}

Modified: trunk/freenet/src/freenet/support/FileLoggerHook.java
===================================================================
--- trunk/freenet/src/freenet/support/FileLoggerHook.java	2007-03-17 14:10:24 UTC (rev 12182)
+++ trunk/freenet/src/freenet/support/FileLoggerHook.java	2007-03-17 14:47:47 UTC (rev 12183)
@@ -862,7 +862,7 @@
 				listBytes += (buf.length + LINE_OVERHEAD);
 			}
 			if (sz == 0)
-				list.notify();
+				list.notifyAll();
 		}
 	}
 




More information about the cvs mailing list