[freenet-cvs] r12173 - trunk/freenet/src/freenet/store

[nextgens at freenetproject.org]

Author: nextgens
Date: 2007-03-17 12:22:29 +0000 (Sat, 17 Mar 2007)
New Revision: 12173

Modified:
   trunk/freenet/src/freenet/store/BerkeleyDBFreenetStore.java
Log:
I spotted a potential problem in the schrinking code... But I'm not sure I understand what's going on :$

tooooaaaaddd, heeelllppp meeee

Modified: trunk/freenet/src/freenet/store/BerkeleyDBFreenetStore.java
===================================================================
--- trunk/freenet/src/freenet/store/BerkeleyDBFreenetStore.java	2007-03-17 12:16:36 UTC (rev 12172)
+++ trunk/freenet/src/freenet/store/BerkeleyDBFreenetStore.java	2007-03-17 12:22:29 UTC (rev 12173)
@@ -1007,7 +1007,7 @@
 						if(i-1 >= maxBlocks)
 							t = environment.beginTransaction(null,null);
 						else
-							t = null;
+							t = null; //FIXME: WTF ? what are we doing here ? if we dereference it, how will the t.commit() out of the loop work? btw, what's the purpose of the test above ? 
 					}
 
 					freeBlocks.remove(i);