[freenet-cvs] r11548 - trunk/freenet/src/freenet/support

[zothar at freenetproject.org]

Author: zothar
Date: 2007-01-03 02:10:48 +0000 (Wed, 03 Jan 2007)
New Revision: 11548

Modified:
   trunk/freenet/src/freenet/support/Fields.java
Log:
Comment about an NPE I got in support/Fields.java; I'm not familiar enough with the code to be sure a if null test is smart there.

Modified: trunk/freenet/src/freenet/support/Fields.java
===================================================================
--- trunk/freenet/src/freenet/support/Fields.java	2007-01-03 00:07:06 UTC (rev 11547)
+++ trunk/freenet/src/freenet/support/Fields.java	2007-01-03 02:10:48 UTC (rev 11548)
@@ -157,6 +157,11 @@
 
 	public static final String[] commaList(String ls) {
 		StringTokenizer st = new StringTokenizer(ls, ",");
+		// FIXME: Next line can NPE
+		//       at java.lang.String.charAt(String.java:560)
+		//       at java.util.StringTokenizer.skipDelimiters(StringTokenizer.java:234)
+		//       at java.util.StringTokenizer.countTokens(StringTokenizer.java:406)
+		//       at freenet.support.Fields.commaList(Fields.java:160)
 		String[] r = new String[st.countTokens()];
 		for (int i = 0; i < r.length; i++) {
 			r[i] = st.nextToken().trim();