[freenet-cvs] r11838 - trunk/freenet/src/freenet/node

[nextgens at freenetproject.org]

Author: nextgens
Date: 2007-02-18 20:26:08 +0000 (Sun, 18 Feb 2007)
New Revision: 11838

Modified:
   trunk/freenet/src/freenet/node/PeerNode.java
Log:
Looking at #1162, I wondered why not using LinkedHashSets ... .toArray is expensive if it's not linked

Modified: trunk/freenet/src/freenet/node/PeerNode.java
===================================================================
--- trunk/freenet/src/freenet/node/PeerNode.java	2007-02-18 20:10:26 UTC (rev 11837)
+++ trunk/freenet/src/freenet/node/PeerNode.java	2007-02-18 20:26:08 UTC (rev 11838)
@@ -18,10 +18,10 @@
 import java.net.UnknownHostException;
 import java.security.MessageDigest;
 import java.util.Arrays;
-import java.util.HashSet;
 import java.util.Hashtable;
 import java.util.Iterator;
 import java.util.LinkedList;
+import java.util.LinkedHashSet;
 import java.util.Vector;
 import java.util.zip.DataFormatException;
 import java.util.zip.Inflater;
@@ -292,7 +292,7 @@
     private boolean allowLocalAddresses;
     
     /** Extra peer data file numbers */
-    private HashSet extraPeerDataFileNumbers;
+    private LinkedHashSet extraPeerDataFileNumbers;
 
     /** Average proportion of requests which are rejected or timed out */
     private TimeDecayingRunningAverage pRejected;
@@ -304,7 +304,7 @@
     private int privateDarknetCommentFileNumber;
     
     /** Queued-to-send N2NTM extra peer data file numbers */
-    private HashSet queuedToSendN2NTMExtraPeerDataFileNumbers;
+    private LinkedHashSet queuedToSendN2NTMExtraPeerDataFileNumbers;
 
     /** Total low-level input bytes */
     private long totalBytesIn;
@@ -628,10 +628,10 @@
         privateDarknetCommentFileNumber = -1;
 
 		// Setup the extraPeerDataFileNumbers
-		extraPeerDataFileNumbers = new HashSet();
+		extraPeerDataFileNumbers = new LinkedHashSet();
 		
 		// Setup the queuedToSendN2NTMExtraPeerDataFileNumbers
-		queuedToSendN2NTMExtraPeerDataFileNumbers = new HashSet();
+		queuedToSendN2NTMExtraPeerDataFileNumbers = new LinkedHashSet();
 		
 		SHA256.returnMessageDigest(md);
     }