[freenet-cvs] r14496 - trunk/freenet/src/freenet/node/fcp

[toad at freenetproject.org]

Author: toad
Date: 2007-08-06 21:21:41 +0000 (Mon, 06 Aug 2007)
New Revision: 14496

Modified:
   trunk/freenet/src/freenet/node/fcp/TestDDACompleteMessage.java
Log:
comment: this shouldn't be a side-effect, it should be done somewhere closer to the main flow

Modified: trunk/freenet/src/freenet/node/fcp/TestDDACompleteMessage.java
===================================================================
--- trunk/freenet/src/freenet/node/fcp/TestDDACompleteMessage.java	2007-08-06 19:10:45 UTC (rev 14495)
+++ trunk/freenet/src/freenet/node/fcp/TestDDACompleteMessage.java	2007-08-06 21:21:41 UTC (rev 14496)
@@ -63,6 +63,7 @@
 			sfs.putSingle(WRITE_ALLOWED, String.valueOf(isWriteAllowed));
 		}
 		
+		// FIXME this really shouldn't be a side-effect!
 		handler.registerTestDDAResult(checkJob.directory.toString(), isReadAllowed, isWriteAllowed);
 		
 		return sfs;